-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add admonition feature #210
Conversation
Question @iterative/websites : why are there so many icons and which style does each one use? E.g. looks like "exclamation" is type "warn" but with another icon. A bit confusing (minor) |
Essentially there are three type that come with their own color: While these come with default emojis, you can update any type to use a different icon if you'd like by using the |
Got it. The |
No wait... In this PR we used |
It actually didn't render as As for how you still got the exclamation, even though the
We probably don't want that behavior though. I'll open a pr that stops |
I see.
Ok that's the unexpected part indeed. Thanks! |
Not sure extra icons not linked to type are useful. Seems to break theme/convention IMO. |
Basically a copy of dvc.org#3371
Code Example:
Design:
Type options:
info
(default emoji is ℹ️)tip
(default emoji is 💡)warn
(default emoji isIcon options:
tip - 💡⚠️
info - ℹ️
warn -
fire - 🔥
exclamation - ❗
beetle - 🐞